Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a nimibook / license module #87

Open
pietroppeter opened this issue Oct 23, 2023 · 2 comments
Open

a nimibook / license module #87

pietroppeter opened this issue Oct 23, 2023 · 2 comments

Comments

@pietroppeter
Copy link
Owner

thanks to #86 we now have a license page that lists licenses for all assets bundled with nimibook.
we could make the text of the list of licenses a constant in a new nimibook / license module so that other project using nimibook (such as owlkettle where this issue originated, see #80) can reuse that and be updated when content is updated.

@PhilippMDoerner
Copy link
Contributor

PhilippMDoerner commented Oct 24, 2023

Does this include a way for the user to add their own tuple[assetName: string, licenseName: string] list to display on top of the ones nimibook will add?

Maybe even split them out, one section for nimibook related licenses, a second section on the same page for all project-specific related licenses?

@pietroppeter
Copy link
Owner Author

Mmh, initially I was thinking of a single const string of text, but now that you mention it we could have also tuples for each license asset (name of asset, name of license but maybe also url?). I would not want this too complicated, anyway it is easy for the user to customize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants