Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: a show source button or similar #60

Open
pietroppeter opened this issue Jan 25, 2023 · 4 comments
Open

feature: a show source button or similar #60

pietroppeter opened this issue Jan 25, 2023 · 4 comments
Labels
2023H1 priority for first half of 2023 enhancement New feature or request
Milestone

Comments

@pietroppeter
Copy link
Owner

  • not a feature that is present in original mdbook but it is something which makes a lot of sense: the idea is to have a way to directly show the source code of the page as we do in nimib
  • since this is not native in mdbook what needs to be decided is how this elements should appear in the interface: a button? where?
@pietroppeter pietroppeter added the enhancement New feature or request label Jan 25, 2023
@HugoGranstrom
Copy link
Collaborator

Agreed, always nice to show the simple source code behind an impressive page :) Here are my two cents:

Both on mobile and desktop we have some space at the bottom of the screen. So we could place it like we do in ordinary nimib. Maybe we would want to center it here though.
The other option I can come up with is adding a button to the header, but it gets a bit too crammed on mobile if you have a longer book title.

@pietroppeter
Copy link
Owner Author

On mobile it could be here. Definitely header is already packed

image

@HugoGranstrom
Copy link
Collaborator

Yes, that should work 👍 I looked at the HTML template and we will have to add the desktop button separately as the chapter buttons along with their parent div is hidden on desktop.

@HugoGranstrom
Copy link
Collaborator

I have given this a small try, but the CSS-part of my brain isn't collaborating... So I'll skip this in the current PR, and we'll see if I revisit this later (or if someone else does it before me).

@pietroppeter pietroppeter added the 2023H1 priority for first half of 2023 label Jan 29, 2023
@pietroppeter pietroppeter added this to the 2023H1 milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023H1 priority for first half of 2023 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants