-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial CRAN release checklist #4
Comments
Update: added tests in 585c43a |
Update: implemented simple linear interpolation to get values at rounded wavenumbers in 3ad5547 |
Update: The documentation of the output was updated in 70bd2c0 and e424534 @philipp-baumann could you please review? |
@pierreroudier Shall I make a new pull request to review your commit? |
@philipp-baumann Sure -- love the PRs :) Discussion in #2 will help refine the docs too. |
New suggestions
|
Agree this would be a valuable addition. with However, I'd be keen to do our first CRAN submit with a package a simple as possible (the initial CRAN submission is always much harder than the subsequent ones in my experience), if we can hold off for a couple weeks. @philipp-baumann I have created a dedicated issue/enhancement request to track progress on this: #8 |
Hi Pierre, yes that's fine with me to wait until first CRAN release is scheduled. I might play around with some stuff in some devel branch in my fork. Will let you know. |
This one as a suggestion before our first CRAN submission
|
Done in 2f0014f. Thanks for pointing it out, it's an awesome tool! |
Issue #2 has been closed, which is ticking off the last item remaining before attempting our first CRAN release! Please review. I will update the dev version number to reflect change, and update |
@philipp-baumann I have been slowly getting back into |
extract
options to more explicit values (issue Refactoring of theextract
option #2)simplify
option (issue Concatenating spectra with thesimple
option #3). We could either:simplify = FALSE
if the user wants exact wavenumberssimplify = FALSE
@philipp-baumann feel free to add anything you think might be required before CRAN submission.
The text was updated successfully, but these errors were encountered: