Writer: initialize the writer on Flush() if wasn't initialized before #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows compressing empty files, because without this change the proper headers were not emitted when reading an empty file via e.g. io.Copy(). Signed-off-by: Nikolay Edigaryev <[email protected]>
edigaryev
added a commit
to cirruslabs/vetu
that referenced
this pull request
Nov 22, 2023
This happens when attempting to compress a disk that is empty (0 bytes).
edigaryev
added a commit
to cirruslabs/vetu
that referenced
this pull request
Nov 22, 2023
…ll,push} --insecure` command-line argument (#27) * vetu login: validate credentials and support --no-validate * Chunker: fix NPE when Close()'ing a chunker with no Write()s made on it * Chunker: always emit at least one chunk on Close() This may happen when no Write()s were made. * Work around pierrec/lz4#212 This happens when attempting to compress a disk that is empty (0 bytes). * Hide progress bar when the size of disk to be pulled is zero (0 bytes) * vetu {pull,push}: support --insecure * dockerhosts: fix comments
edigaryev
added a commit
to cirruslabs/vetu
that referenced
this pull request
Jan 8, 2024
The fix was was merged[1] and released upstream. [1]: pierrec/lz4#212
edigaryev
added a commit
to cirruslabs/vetu
that referenced
this pull request
Jan 8, 2024
* No need for the github.com/pierrec/lz4/v4 work-around anymore The fix was was merged[1] and released upstream. [1]: pierrec/lz4#212 * Sentry integration * Fix linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows compressing empty files, because without this change the proper headers were not emitted when reading an empty file via e.g.
io.Copy().