[development-v6] Top Domains and Top Clients are not hidden when they contain no data

[mwoolweaver]

was originally opened as pi-hole/pi-hole/issues/5699 in error

Versions

Core
Version is v5.18.2-400-g8b324741 (Latest: null)
Branch is development-v6
Hash is 8b324741 (Latest: 8b324741)

Web
Version is v5.19-818-ge852fbb2 (Latest: null)
Branch is development-v6
Hash is e852fbb (Latest: e852fbb )

FTL
Version is vDev-5c97d29 (Latest: null)
Branch is development-v6
Hash is 5c97d290 (Latest: 5c97d290 )

Platform

• OS and version: Ubuntu 24.04 LTS

• Platform: Raspberry Pi 4 Model B Rev 1.1

Expected behavior

when privacy mode is set to anything other than Show Everything the last 4 boxes should be hidden when they contain no data.

Actual behavior / bug

when privacy mode is set to anything other than Show Everything the last 4 boxes show a loading wheel endlessly when they contain no data.

Steps to reproduce

Steps to reproduce the behavior:

1. set privacy mode to anything other than Show Everything
2. go to the dashboard
3. Scroll down to the bottom of the dashboard (http://pi.hole/admin/)
4. See boxes with loading wheels, how many depends on privacy mode selection ( as seen in screenshots )

Debug Token

• URL: https://tricorder.pi-hole.net/tog4t1Nu/

Screenshots

This is when Anonymous mode & Hide domains and clients is selected

This is when Hide domains is selected

Additional context

Worth noting is an old issue that's very similar #932 the fix was #966

[mwoolweaver]

it seems the graphs shouldn't be shown when empty if I'm looking at this correctly

web/scripts/pi-hole/js/index.js

Lines 24 to 32 in e852fbb

	function updateQueriesOverTime() {
	$.getJSON("/api/history", function (data) {
	// Remove graph if there are no results (e.g. new
	// installation or privacy mode enabled)
	if (jQuery.isEmptyObject(data.history)) {
	$("#queries-over-time").remove();
	return;
	}

web/scripts/pi-hole/js/index.js

Lines 136 to 144 in e852fbb

	function updateClientsOverTime() {
	$.getJSON("/api/history/clients", function (data) {
	// Remove graph if there are no results (e.g. new
	// installation or privacy mode enabled)
	if (jQuery.isEmptyObject(data.history)) {
	$("#clients").remove();
	return;
	}

[yubiuser]

You're correct. (This shows how many of us use anything besides "Show everything").

The fix is simple...

[yubiuser]

Please try if pihole checkout web fix/privacy is fixing the issue for you

[mwoolweaver]

shows an empty graph still

could this be because of

web/scripts/pi-hole/js/index.js

Lines 295 to 298 in e852fbb

	// Add note if there are no results (e.g. privacy mode enabled)
	if (jQuery.isEmptyObject(data.clients)) {
	clienttable.append('<tr><td colspan="3"><center>- No data -</center></td></tr>');
	}

web/scripts/pi-hole/js/index.js

Lines 352 to 355 in e852fbb

	// Add note if there are no results (e.g. privacy mode enabled)
	if (jQuery.isEmptyObject(data.domains)) {
	domaintable.append('<tr><td colspan="3"><center>- No data -</center></td></tr>');
	}

[yubiuser]

Yes. But I think it's fine to show the empty table with "No data".

[mwoolweaver]

I'll close this as fixed then since it is working as intended but aesthetically it would look better if hidden when empty.

[rdwebdesign]

Just remember to return to the v6 branch using pihole checkout web development-v6.

[mwoolweaver]

yes i have switched back, thank you for the reminder.

for anyone in the future that comes across this there is a work around via uBlock Origin

add the following to your custom filters

pi.hole##div.col-lg-6:has-text(No data)

without the filter & privacy mode is Hide domains

with the filter & privacy mode is Hide domains

[mwoolweaver]

Yes. But I think it's fine to show the empty table with "No data".

@yubiuser shouldn't all empty graphs be treated the same?? the clients over time graph gets hidden when it has no data to show (e.g. when privacy mode is Hide domains and clients or Anonymous mode)

see #3072 for more information