-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of new theorems #727
Comments
This is great! I have not looked in detail, but any result that was not previously derivable is a good addition to pi-base. Even better if the new result allows to derive new traits for some spaces, or to remove some redundant traits or strengthen previous results for example. I'd say just go for it and create some PRs, so each result can be analyzed and discussed. One recommendation. Please do not create one huge PR with all the results. Instead, you can start creating some PR, one result at a time (or maybe more than one if two results are closely linked and need to be discussed together). That will make it easier to review and get things approved. If there are dependencies between results, it may be even better to wait until each PR is approved before starting the next one, so we can better see the dependencies when playing with it in the database. If each PR is short, we should be able to get to it quickly. Also the usual guideline. Proofs that are short and pretty straightforward can be written directly in pi-base as justification. But anything more involved should refer to some post on mathse (or to something in books or the published literature of course). |
💯 👆 Looking forward to your contributions @Jianing-Song :-D |
Hi everyone, I will be soon back from summer holiday, and I would like to add the following theorems:
How do you think of these theorems? Please don't hesitate to share your concerns! Thank you in advance.
The text was updated successfully, but these errors were encountered: