Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrase editor unexpected behaviour when using css class hidden #63

Open
SofieAndersen opened this issue Aug 22, 2024 · 1 comment
Open

Comments

@SofieAndersen
Copy link

Expected behavior
CSS 'hidden' should not impact phrase context editor. This is especially an issue when using tailwind css since that is using 'hidden' as a utility class that will be used in combination with a display class for certain breakpoints.

Actual behavior
When using css 'hidden' in combination with other css classes phrase context editor does not pick up the translation and displays the raw {{__phrase_hero_title__}} without an option to edit even though the element is full visible

Screenshot 2024-08-22 at 13 44 22

Your environment
N/A

Steps to reproduce the problem
See: https://stackblitz.com/edit/stackblitz-starters-o6notr

Setup to use

projectId: '00000000000000004158e0858d2fa45c',
accountId: '0bed59e5',

login with user: [email protected] pw: phrase

In this example I ended up using the inline js script and a hard coded value. However when using ngx-translate-phraseapp the exact same issue occurs. Since the PhraseAppCompiler simply transforms all the translations and the translate pipe simple outputs the transformed keys.

Also mention in: phrase/i18next-phrase-in-context-editor-post-processor#175

Additionally
I noticed a small ui issue with the context editor; when you have multiple translations close to each other the dropdown when editing falls below other edit buttons

Screenshot 2024-08-22 at 13 42 04

@itsahsiao
Copy link
Contributor

HI @SofieAndersen, thank you for reporting this! We'll look into it and see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants