-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change data format of timeCreated
on users
table`
#87
Comments
This is also used in the ConversationRepository for conversation 'started_at' will it need to be changed there aswell? |
Yes. Anywhere we are using that will need to be changed since MySQL will throw up there too. I had just noticed it on the Users table. |
I can work on that. Other changes needs to be made on the tables too, such as NOT NULL fields being filled up empty because we are not validating it on the code. Also, @dragonmantank can you confirm to me what the production charset for the database and following tables are? We are running on MySQL 5.5, the default is latin1, just so I can test correctly here. |
Is this still an issue? If so I can tackle this one :) |
@ragnaro89 Yes, it should still be an issue. Feel free to make the changes and send in a PR :) |
We are currently using
\DateTime::ISO8601
to populate thetimeCreated
field for users. This needs to be changed toY-m-d H:i:s
format, as using the ISO format causes MySQL 5.7 to throw an error about a bad date format.Only critical once we decide to upgrade from MySQL 5.5.
The text was updated successfully, but these errors were encountered: