Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data format of timeCreated on users table` #87

Open
dragonmantank opened this issue Oct 21, 2016 · 5 comments
Open

Change data format of timeCreated on users table` #87

dragonmantank opened this issue Oct 21, 2016 · 5 comments
Labels

Comments

@dragonmantank
Copy link
Member

dragonmantank commented Oct 21, 2016

We are currently using \DateTime::ISO8601 to populate the timeCreated field for users. This needs to be changed to Y-m-d H:i:s format, as using the ISO format causes MySQL 5.7 to throw an error about a bad date format.

Only critical once we decide to upgrade from MySQL 5.5.

@sprunka
Copy link
Contributor

sprunka commented Feb 4, 2017

This is also used in the ConversationRepository for conversation 'started_at' will it need to be changed there aswell?

@dragonmantank
Copy link
Member Author

Yes. Anywhere we are using that will need to be changed since MySQL will throw up there too. I had just noticed it on the Users table.

@gabidavila
Copy link
Contributor

gabidavila commented Mar 2, 2017

I can work on that.

Other changes needs to be made on the tables too, such as NOT NULL fields being filled up empty because we are not validating it on the code.

Also, @dragonmantank can you confirm to me what the production charset for the database and following tables are? We are running on MySQL 5.5, the default is latin1, just so I can test correctly here.

@ragnaro89
Copy link

Is this still an issue? If so I can tackle this one :)

@dragonmantank
Copy link
Member Author

@ragnaro89 Yes, it should still be an issue. Feel free to make the changes and send in a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants