Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geolocation to the user on editing the user-informations #55

Open
heiglandreas opened this issue Sep 2, 2015 · 2 comments
Open

Comments

@heiglandreas
Copy link
Contributor

heiglandreas commented Sep 2, 2015

Currently no geolocation is set for a user.

To enable any kind of location-based feature it would be a great idea to directly have the geolocation (in form of latitude and longitude) as part of the users information.

On login it would be possible to check the github-API for the location of the user and pass that to nominatim (http://nominatim.openstreetmap.org/search?format=json&q=[url_encoded location]) and use the first result as default. That vaoue could then be displayed on a map for the user to "relocate" that default value to something more appropriate for her or him.

I'm using the first part of that approach on http://php.ug/#mentoring by currently parsing the wikis HTML, retrieving the github-usernames, geting the users location and passing that to nominatim. If nothing sensible comes back from nominatim (due to it not being able to resolve the value in the users location-info) the user will not be displayed on the map. That could be much easier if the user can alter that location just for phpmentoring.

That would ease Geographic filtering (#20) on the site itself and on php.ug I could simply consume the API and would not have to do a nightly parsing run and use a local cache for getting the data.

@PurpleBooth
Copy link
Contributor

I feel that this is partly addressed with my PR #63, the introduction of a user's preferred timezone at least allows you to identify users that will be awake at the same time as you.

@heiglandreas
Copy link
Contributor Author

As you say, it's only partially....

The timezone gives us the information on when a User (might) be awake. But it does not give us the information whether the user is near my own location or not, whether I might be able to talk to the user in my own language or not or might be able to have real face-to-face meetings. And it makes it way harder to put a pin onto a map to show where a user lives 😉. No one says that you have to give your exact location, but you can if you want to.

And from the geolocation we can easily get the correct timezone 😉

For the old listing I parsed the location the user provided in the github-account info (if available) and when no reasonable result was found there wasn't a pin shown on the map. And when someone said "Germany" as location the pin was positioned right in the middle of germany.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants