Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Refresh #27

Open
dragonmantank opened this issue May 28, 2015 · 14 comments
Open

Visual Refresh #27

dragonmantank opened this issue May 28, 2015 · 14 comments

Comments

@dragonmantank
Copy link
Member

dragonmantank commented May 28, 2015

Make the site not look ugly.

@ericnkatz
Copy link

Hi, I'm Eric!

I started work on this, this past weekend pulling in some colors form the main php.net site like purples/dark gray. I removed bootstrap and am now wondering if there was a specific reason for the Angular or if I could switch to some other front end JS framework.

I know I'm being kind of vague about this but I'll update my fork once I get the navigation set up and open it up for feedback prior to any sort of PR.

@dragonmantank
Copy link
Member Author

I only picked Angular because it was the one I tend to use the most, and we can scale it up or down depending on the need, such as having small widgets like the search pages, or full-blown mini-SPAs for different sections.

If you're thinking about swapping the JS frameworks, I'd do that in a separate branch from the visual refresh, as I'm sure there will be some back-and-forth from people that I wouldn't want to stall the visual changes.

@ericnkatz
Copy link

@dragonmantank sounds good to me. This is where I'm at right now for full width basic content pages: http://codepen.io/ericnkatz/full/a3cad612b08d8755a5f26328107f57de/ I have an update in progress for homepage that includes a larger hero image and placeholder for like find a mentor or become a mentor blocks.

Still need to tweak some footer pieces and add some user interaction, but what are your thoughts so far for direction?

@dragonmantank
Copy link
Member Author

So far I think it looks great! Thank you!

Having a CTA on the find/become on the homepage would be a big plus, since that's the main purpose of the site. The content on the page looks and reads well to me, which is good because down the road we'll be adding more flat content, in addition to the searching.

@christickner
Copy link
Member

👍 nice, thanks @ericnkatz !

@kylestev
Copy link

looks nice! 👍

@ericnkatz
Copy link

Publishing my changes/ next revision this weekend. Sorry for the delay. :)

@dragonmantank
Copy link
Member Author

Great, looking forward to it. Thank you for all the hard work!

@dragonmantank
Copy link
Member Author

@ericnkatz Just wanted to follow up on this. We're hoping to go live sometime this weekend. If it still needs some polishing that's cool, we'll merge in your changes whenever you are ready.

@ericnkatz
Copy link

@dragonmantank on it, going to re-pull your changes and merge my styles/markup.

@tdutrion
Copy link
Contributor

Any update here?

If the current design upgrade is aborted, I could help with that by pulling in some Google Material Design or Twitter bootstrap but can't really provide more than that... I guess that would be modern enough.

@ericnkatz
Copy link

This is what I have right now: https://github.com/ericnkatz/phpmentoring/tree/frontend

@dragonmantank
Copy link
Member Author

It looks great. Feel free to send over a PR. I think there will be some merge conflicts, but we can get those ironed out.

@christickner
Copy link
Member

@ericnkatz how is this going? Can you setup a PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants