Move myphpnet_* functions to the UserPreferences class #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauricioFauth
requested review from
saundefined and
sy-records
as code owners
|
🚀 Regression report for commit 4c23310 is at https://web-php-regression-report-pr-1075.preview.thephp.foundation |
|
🚀 Preview for commit 4c23310 can be found at https://web-php-pr-1075.preview.thephp.foundation |
MauricioFauth
force-pushed
the
myphpnet-functions
branch
from
c3d71ba
to
49d5aac
Compare
saundefined
approved these changes
Nov 9, 2024
|
In my opinion, a very good change, especially since we now have more code under test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all
myphpnet_*functions to theUserPreferencesclass and changes its static properties to instance properties.