New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'impact.game' is not actually required by Weltmeister #64

Open

Joncom opened this issue Sep 5, 2019 · 1 comment

Collaborator

Joncom commented Sep 5, 2019 •

edited

Loading

Impact/lib/weltmeister/weltmeister.js

Lines 7 to 9 in 70f34c8

 .requires( 

 'dom.ready', 

 'impact.game',

ig.Game is not used, so this line doesn't need to be here, right?

The text was updated successfully, but these errors were encountered:

Owner

phoboslab commented Sep 5, 2019

Right. I think this is in there as a shorthand to require impact.entity.:

Impact/lib/impact/game.js

Lines 4 to 9 in 70f34c8

 .requires( 

 'impact.impact', 

 'impact.entity', 

 'impact.collision-map', 

 'impact.background-map' 

 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment