Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The phar for 2.11.0 is broken #101

Open
glensc opened this issue Jan 25, 2021 · 4 comments
Open

The phar for 2.11.0 is broken #101

glensc opened this issue Jan 25, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@glensc
Copy link
Contributor

glensc commented Jan 25, 2021

Bug Report

Q A
BC Break no
Version 2.11.0

Summary

Latest .phar is broken, tested with:

➔ php74  ~/Downloads/keep-a-changelog.phar --version
PHP Fatal error:  Uncaught Error: Class '_HumbugBoxe3316aeaf337\Composer\InstalledVersions' not found in phar:///Users/glen/Downloads/keep-a-changelog.phar/vendor/ocramius/package-versions/src/PackageVersions/Versions.php:32
@glensc glensc added the bug Something isn't working label Jan 25, 2021
@glensc
Copy link
Contributor Author

glensc commented Jan 25, 2021

2.10.1 seems ok:

➔ php74  ~/Downloads/keep-a-changelog\ \(1\).phar --version
keep-a-changelog 2.10.1

@glensc glensc changed the title Latest phar is broken The phar for 2.11.0 is broken Jan 25, 2021
@weierophinney
Copy link
Contributor

This appears to be due to updating to ocramius/package-versions v2, which proxies to the internal functionality provided by Composer for exposing package versions... which evidently doesn't play nicely with the way we build our phar.

@heiglandreas Have you seen similar on any other projects you work on?

@heiglandreas
Copy link
Contributor

Not yet @weierophinney. Will dig into it on the weekend.

@weierophinney
Copy link
Contributor

I've figured out a solution that bypasses it (basically, using the tag as provided to the workflow as the version, and slipstreaming that into the bin/keep-a-changelog script); this may actually be slightly better for PHAR purposes, but it also means maintaining both the original script and a .dist file, which always leads to mismatches. I'll keep my changes locally, and see if you can find another solution, @heiglandreas :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants