-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panning after opening modal pans map to last location #527
Comments
Also, when modal is opened and then closed, and then near me button is clicked, no pan. |
Hey. Just started by trying to reproduce the stated issues. There are a few notable points. Here are the findings:
Note also that at the moment, I believe current location would be the default current location (around city hall I believe) when location services are off. |
Hi. I'm leaving some of my testing notes here, which organizes the various cases, in case someone else finds it helpful in debugging.
|
This fixes the issue where opening a site, then clicking "Near Me", then closing the info modal was panning back to the prior site, whereas it should have stayed at the "Near Me" site. This is "issue C" as discussed in the comments of GitHub issue #527.
Proposed fix for the issues here is provided in PR #539. |
Describe the bug
In desktop mode (and presumably mobile too) the map will pan to the last location visited specifically after opening the modal and not closing it.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect the map to pan to the new location, e.g. Franklin D. Roosevelt Park.
The text was updated successfully, but these errors were encountered: