Provide own instance of IPhase4PeppolIncomingSBDHandlerSPI

[Florianisme]

Hi Philip,

I am currently using your library in a Spring Boot Project. I have provided an implementation of the IPhase4PeppolIncomingSBDHandlerSPI Interface through SPI which is working fine.

It was however always a headache for me to do it this way because I have to use Autoinjected Dependencies in that class. That meant that I had to keep a reference to the Spring Context and manually inject my dependencies that way.

It would be way easier if I could register a Provider or Factory instance in your library which then provides an instance of my implementation for your library to use. This class can be kept completely Spring-free.

What do you think about this idea?

[phax]

Hi Florian, Thanks for reaching out to me.
I took the liberty and converted this to a discussion rather then an issue. If we agree on the solution, we may end up in an issue :)

I think I understand your considerations, even though I am not a Spring expert (please bare that in mind when you read the rest of my suggestion).

Making the change you suggested would mean a breaking change for all existing users. Instead I would like to suggest a different solution that just takes one more level of indirection.

• So the proposal is to stay with the SPI solution
• You keep your SPI handler implementation class (calling it FlorianSPI :) )
• Inside FlorianSPI you add a static method "registerHandler (yourInterface)` - the interface should be a subset of SPI interface (you can even reduce the parameters to the ones you need)
• Everytime the SPI part of FlorianSPI is invoked, you just forward the call to your registered handler from the previous step

With this solution, you are losing a few nanonseconds for the indirection, but finally you have an object that is fully injected and you can do whatever you need.

How does that sound to you?

[phax]

Hi Florian,
Thanks for the positive response. Happy to hear that it works :)

I will try to include something like this as an example code into the "spring-boot-demo" - it may makes sense to point others to this solution.

This discussion cannot be closed - it stays open. If would be nice if you could select my answer as the "selected answer" so that others reading the thread are directly routed to the selected solution.

Happy coding :)

[phax]

Update: see commit b40ef99 for the respecitve commit

[Florianisme]

I actually can't select your response as the "selected answer" - at least I don't see any button for it anywhere :D

[phax]

Honestly I don't know either. I just saw it on #113

[Florianisme]

Yeah I've seen that.

Maybe it is because you opened the discussion from my issue. Even though it shows my name as the author. Strange.