Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developing with [email protected] #62

Closed
kentonvp opened this issue Jan 11, 2024 · 7 comments
Closed

Developing with [email protected] #62

kentonvp opened this issue Jan 11, 2024 · 7 comments

Comments

@kentonvp
Copy link
Contributor

Hi! I'd love to contribute to this package. I currently have [email protected] installed:

julia> VERSION
"v1.10.0"

I have forked the repository, but when I attempt to develop, I get the following warning

julia> using RLEVectors
┌ Warning: The active manifest file is an older format with no julia version entry. Dependencies may have been resolved with a different julia version.
└ @ ~/dev/RLEVectors.jl/Manifest.toml:0

I really want to tackle some of the issues, but cannot run anything unless I update the Manifest.toml using Pkg; Pkg.upgrade_manifest() and then after that, run a Pkg.update().

Can I submit a PR to upgrade the Manifest.toml? or can the Manifest.toml be removed completely? (I know some projects do not include it in their repos.)

Thanks! Let me know if there is anything I can do.

@phaverty
Copy link
Owner

Awesome, I'd love to see that update. Please submit a PR. Thank you!

@kentonvp
Copy link
Contributor Author

Done! #63

@phaverty
Copy link
Owner

Fixed by #63
@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Error while trying to register: Version 0.9.9 already exists

@phaverty
Copy link
Owner

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/98760

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.10.0 -m "<description of version>" e59e46ae4d070b56997ea83ec23beb42baa9f58c
git push origin v0.10.0

@phaverty
Copy link
Owner

Thanks, @kentonvp , I've included this change and I've also updated all the CI stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants