From 82da36492a60bb6a48cb062841f53d37851a5e0c Mon Sep 17 00:00:00 2001
From: Matthew Swartwout <mwswartwout@users.noreply.github.com>
Date: Wed, 15 May 2024 12:39:10 -0700
Subject: [PATCH] Use data() instead of begin() in Protocols.cpp (#33476)

* Use data() instead of begin() in Protocols.cpp

The GetProtocolName() function tries to store the result of
std::array<T>::begin() in a raw pointer type, but this no longer works
on some newer versions of clang, since clang now returns an iterator
object. This change fixes this by switching to std::array<T>::data()
instead, which always returns a raw pointer.

* Restyled by whitespace

---------

Co-authored-by: Restyled.io <commits@restyled.io>
---
 src/protocols/Protocols.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/protocols/Protocols.cpp b/src/protocols/Protocols.cpp
index f840bb097249a9..4428d8c8b1540b 100644
--- a/src/protocols/Protocols.cpp
+++ b/src/protocols/Protocols.cpp
@@ -86,27 +86,27 @@ const char * GetMessageTypeName(Id protocolId, uint8_t msgType)
     switch (protocolId.GetProtocolId())
     {
     case InteractionModel::Id.GetProtocolId():
-        lookupTable     = MessageTypeTraits<InteractionModel::MsgType>::GetTypeToNameTable()->begin();
+        lookupTable     = MessageTypeTraits<InteractionModel::MsgType>::GetTypeToNameTable()->data();
         lookupTableSize = MessageTypeTraits<InteractionModel::MsgType>::GetTypeToNameTable()->size();
         break;
 
     case SecureChannel::Id.GetProtocolId():
-        lookupTable     = MessageTypeTraits<SecureChannel::MsgType>::GetTypeToNameTable()->begin();
+        lookupTable     = MessageTypeTraits<SecureChannel::MsgType>::GetTypeToNameTable()->data();
         lookupTableSize = MessageTypeTraits<SecureChannel::MsgType>::GetTypeToNameTable()->size();
         break;
 
     case BDX::Id.GetProtocolId():
-        lookupTable     = MessageTypeTraits<bdx::MessageType>::GetTypeToNameTable()->begin();
+        lookupTable     = MessageTypeTraits<bdx::MessageType>::GetTypeToNameTable()->data();
         lookupTableSize = MessageTypeTraits<bdx::MessageType>::GetTypeToNameTable()->size();
         break;
 
     case Echo::Id.GetProtocolId():
-        lookupTable     = MessageTypeTraits<Echo::MsgType>::GetTypeToNameTable()->begin();
+        lookupTable     = MessageTypeTraits<Echo::MsgType>::GetTypeToNameTable()->data();
         lookupTableSize = MessageTypeTraits<Echo::MsgType>::GetTypeToNameTable()->size();
         break;
 
     case UserDirectedCommissioning::Id.GetProtocolId():
-        lookupTable     = MessageTypeTraits<UserDirectedCommissioning::MsgType>::GetTypeToNameTable()->begin();
+        lookupTable     = MessageTypeTraits<UserDirectedCommissioning::MsgType>::GetTypeToNameTable()->data();
         lookupTableSize = MessageTypeTraits<UserDirectedCommissioning::MsgType>::GetTypeToNameTable()->size();
         break;