Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize existing r4ss functions to reduce redundant code? #21

Open
iantaylor-NOAA opened this issue Mar 29, 2023 · 1 comment
Open

utilize existing r4ss functions to reduce redundant code? #21

iantaylor-NOAA opened this issue Mar 29, 2023 · 1 comment

Comments

@iantaylor-NOAA
Copy link

I skimmed through the functions associated with the sensitivity analysis workflow.
It looks really good, but I can't claim to understand it until trying it out someday in the future.

I do note that you could shrink copy_BaseModel_SSinputs() by having is call on r4ss::copy_SS_inputs().

@MatthVeron
Copy link
Collaborator

Thanks @iantaylor-NOAA and thank you for your time again. I would love to get your feedback on this and improve it accordingly. I'll modify things to account for the comments/suggestions that have been done today.

You're totally right about the r4ss::copy_SS_inputs() function.
I'll probably modify it - This is something that is "under discussion" in my mind because it's possible that we'll develop some sort of "generic stock assessment workflow" based on what we've all developed during this course, so it would be helpful to keep the functions as generic as possible...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants