-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common name check in the pull code #64
Comments
In the past, we've discussed exposing a table of names (common, scientific) in the Data Warehouse as an additional metadata table. That likely won't solve every issue (e.g., users not looking at the metadata) so perhaps integrating some fuzzy logic would also help. |
@kellijohnson-NOAA has integrated some code into the package creating a table of species information in the GetSpp.fn function. My thought is to apply the information created by this function in an internal check for function common name/scientific name input by the user where if a user specifies: PullCatch.fn(Name = "dover sole", SurveyName = "NWFSC.Combo") the function would internally correct the Name input to "Dover sole". Should be fairly simple based on existing functionality for species that are commonly used by the NWFSC. |
Ahh right, I had forgotten about the GetSpp.fn. Sounds like a good plan. |
@chantelwetzel-noaa do you want to just to |
Yes. This is something that has been on my to-do list. Is that approach you are considering is to use |
It is often unclear to users how common species names should be formatted to pull and return data of interest. Creating a function that correct incorrect capitalization (Dover sole vs. dover sole vs Dover Sole) would make pulling data easier for users.
The text was updated successfully, but these errors were encountered: