Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for NOAA DSCRTP to pull coral and sponge records from Data Warehouse #58

Open
Curt-Whitmire-NOAA opened this issue Oct 15, 2021 · 2 comments
Assignees
Labels
warehouse Pertains to getting, documenting, or fixing data in the warehouse.

Comments

@Curt-Whitmire-NOAA
Copy link

Add function, similar to PullCatch.fn to pull the following taxonomic groups from the Data Warehouse trawl_catch_fact table:

  1. All corals and sponges
  2. All corals
  3. All sponges (Phylum Porifera)
  4. All sea pens (Order Pennatulacea)

Curt Whitmire has started creating an R function and will work with other contributors to test and ultimately merge into this package.

@chantelwetzel-noaa
Copy link
Contributor

@Curt-Whitmire-NOAA This is fantastic. Once you have this sketched out, I would love to collaborate to see how we could incorporate this into the main functions. Currently, I am thinking of having a single function to pull a data type (either catch or biological samples) and then with that function have switches or calls to other functions that will define parameters based on the type of data requested (normal survey data, all data including non-standard surveys, coral and sponge data). Hopefully this will limit duplicate code across similar functions and create a streamline data retrieval process.

@Curt-Whitmire-NOAA
Copy link
Author

@chantelwetzel-noaa , that sounds like a great plan! I was wondering how best to offer the user different options for pulling related datasets, and I like your idea of "switches" or calls to other functions. I'll share what I have so far with you soon, but so far I've only copied and modified the PullCatch.fn to pull additional fields that are required for the DSCRTP national database.

@kellijohnson-NOAA kellijohnson-NOAA added the warehouse Pertains to getting, documenting, or fixing data in the warehouse. label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warehouse Pertains to getting, documenting, or fixing data in the warehouse.
Projects
None yet
Development

No branches or pull requests

3 participants