Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run a joint profile #8

Open
chantelwetzel-noaa opened this issue Aug 13, 2021 · 3 comments
Open

Add ability to run a joint profile #8

chantelwetzel-noaa opened this issue Aug 13, 2021 · 3 comments

Comments

@chantelwetzel-noaa
Copy link
Contributor

I think it would be useful to add a function to create a joint profile across two parameters. I have some existing code that could be modified that would facilitate the development of this approach. Currently, I have plotted joint profile space via contour plots (see below). I wanted to create an issue on this topic so users could weigh in what type of figures and tables would be most useful. I think @shcaba has already done some work on this front and would like to make sure that we incorporate approaches that other have been found useful.

base_reg_space_joint_m_profile_dover

@shcaba
Copy link
Contributor

shcaba commented Aug 13, 2021

Multi-parameter likelihoods can be run in the SS-DL (https://github.com/shcaba/SS-DL-tool), but I'd be happy to work to isolate that code for this package.
It is different from the grid search approach being shown in the example above. Maybe we have both options available.

@k-doering-NOAA
Copy link
Contributor

Great idea! I wonder if this belongs in r4ss rather than nwfsc-assess? It sounds general to SS models?

Of course, it could always be moved at a different time, if it seems best to start working on it in nwfsc-assess instead.

@iantaylor-NOAA
Copy link
Contributor

Both SS_DL and nwfscDiag use r4ss::SS_profile(), but wrap it up in a more user-friendly way. The bivariate profile option in r4ss is discussed in r4ss/r4ss#224. I'm on the fence about the pros and cons of incorporating something like those wrappers into r4ss, but it definitely would make sense to add support for some kind of plot of bivariate profile results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants