Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: deprecate run() #23

Open
kellijohnson-NOAA opened this issue Feb 9, 2024 · 2 comments
Open

[Feature]: deprecate run() #23

kellijohnson-NOAA opened this issue Feb 9, 2024 · 2 comments
Assignees
Labels
status--In progress Currently being worked on topic--code type--Enhancement New feature or request

Comments

@kellijohnson-NOAA
Copy link
Collaborator

Describe the problem your feature request is related to.

Model features are too complicated to use a sweet of settings for a massive amount of species. So, instead I have found that a csv file that stores the configurations for each species is a better way forward. Thus, run() which takes a data frame of combinations of survey and species and "splits" them before calling run_sdmtmb() is no longer needed because the latter function is sufficient.

Describe the solution you'd like

Soft deprecate the function at first and then hard deprecate with suggested purrr::map() after dplyr::split() to show users how to use run_sdmtmb().

Describe alternatives you have considered

Keep the function ☹️

Additional context

No response

@kellijohnson-NOAA kellijohnson-NOAA added type--Enhancement New feature or request status--Pretriage Triage needs to happen topic--code labels Feb 9, 2024
@kellijohnson-NOAA kellijohnson-NOAA self-assigned this Feb 9, 2024
@kellijohnson-NOAA
Copy link
Collaborator Author

Started the process in 6c16f68 but @chantelwetzel-noaa can you confirm that you are no longer using the run() function and instead are using run_sdmtmb() in your current scripts?

@kellijohnson-NOAA kellijohnson-NOAA added status--In progress Currently being worked on and removed status--Pretriage Triage needs to happen labels Mar 21, 2024
@chantelwetzel-noaa
Copy link
Collaborator

Thank you for checking. Deprecate away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status--In progress Currently being worked on topic--code type--Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants