Move age_representativeness_plot() to {nwfscSurvey}

[kellijohnson-NOAA]

@chantelwetzel-noaa {nwfscSurvey} is the destination of choice right?

PacFIN.Utilities/R/age_representativeness_plot.R

Line 34 in 4683a3f

age_representativeness_plot <- function(bio,

Before doing so, finish the following tasks

• allow for parameter-based column names for length, age, and year
• convert to {ggplot2}
  • haven't added $\hat{b}$ yet
  • need a better theme
  • only want p value colored not the entire KS test line
• remove some parameters that are not needed
• rename function to something more concise with an action term to start (check, plot)

initial figure that I am working on (mid convert to {ggplot2} is (haven't added $\hat{b}$ yet)

original figure was

[chantelwetzel-noaa]

I think the {nwfscSurvey} is a good location for this. Could I add one more task to your list?

[kellijohnson-NOAA]

You bet @chantelwetzel-noaa! I moved it to my list so I won't forget.

[kellijohnson-NOAA]

I have a question ... should the K-S test and the distributions shown on the figure be from mutually exclusive data or should the comparison be all lengths vs lengths with ages? I am thinking that the comparison should be between lengths without ages versus lengths with ages such that no data point exists in the two data sets being compared.

[brianlangseth-NOAA]

I dont see any reason it has to be one or the other. Originally I did it to compare lengths with aged-lengths distributions, and thus there was some overlap. I think this has undergone adjustments that I haven't been following. So long as the KS test compares the two distributions that are being plotted, I think it is intuitively doing what it is supposed to be doing.