Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCSS soft shadow disappears in specular reflection when light intensity high #19

Open
dmnsgn opened this issue May 31, 2024 · 2 comments

Comments

@dmnsgn
Copy link
Member

dmnsgn commented May 31, 2024

The soft gradient disappears when mixed with the color and the sampling pattern becomes more visible.

Screenshot 2024-05-30 at 22 02 39

Results above with a dir light at intensity 10 and a floor (roughness: 0.15, metallic: 0.75).

Clamping the D term of the brdf to 0->1 helped but that's not physically correct.

@dmnsgn dmnsgn transferred this issue from pex-gl/pex-renderer May 31, 2024
@dmnsgn
Copy link
Member Author

dmnsgn commented May 31, 2024

To note three.js implementation examples shows the same signs:

image

@dmnsgn dmnsgn changed the title PCSS sampling pattern very visible in specular reflection when light intensity high PCSS soft shadow disappears in specular reflection when light intensity high May 31, 2024
@dmnsgn
Copy link
Member Author

dmnsgn commented Jun 6, 2024

This is the assumed behaviour for high reflective surfaces (eg. big metallic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant