Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bloom #11

Open
4 tasks
dmnsgn opened this issue Feb 14, 2024 · 7 comments
Open
4 tasks

Improve Bloom #11

dmnsgn opened this issue Feb 14, 2024 · 7 comments

Comments

@dmnsgn
Copy link
Member

dmnsgn commented Feb 14, 2024

  • add tint color
  • anamorphic ratio
  • lens dirt
  • pack bloom intensity in bloom texture alpha for selective bloom
@vorg
Copy link
Member

vorg commented Apr 25, 2024

  • combine 8 upscale passes adding all blur steps into threshold texture into one final blend pass

@dmnsgn
Copy link
Member Author

dmnsgn commented Apr 25, 2024

  • combine 8 upscale passes adding all blur steps into threshold texture into one final blend pass

Should we also add a blending mode option for this (if we want to blend with screen for instance)?

@vorg
Copy link
Member

vorg commented Apr 25, 2024

if we can make it work, then yes.

@dmnsgn
Copy link
Member Author

dmnsgn commented Jun 7, 2024

  • use bicubic sampling for smooth bloom
  • or use mipmaps directly (WebGL2) instead of rendering to 8 textures

@vorg

This comment was marked as duplicate.

@vorg
Copy link
Member

vorg commented Jun 7, 2024

Are we using Kawase technique here? Very good video on modern bloom that talks about downsampling but also upsampling instead of just blending https://www.youtube.com/watch?v=ml-5OGZC7vE

@dmnsgn
Copy link
Member Author

dmnsgn commented Jun 7, 2024

Are we using Kawase technique here? Very good video on modern bloom that talks about downsampling but also upsampling instead of just blending https://www.youtube.com/watch?v=ml-5OGZC7vE

No, our downsample is 4x4 box filter (+Karis's luma weighted average). No Kuwase, no 13 taps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants