Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call disableVertexAttribArray unless necessary #58

Open
vorg opened this issue Jan 3, 2019 · 0 comments
Open

Don't call disableVertexAttribArray unless necessary #58

vorg opened this issue Jan 3, 2019 · 0 comments
Labels
type/feat A new feature

Comments

@vorg
Copy link
Member

vorg commented Jan 3, 2019

In https://github.com/pex-gl/pex-context/blob/master/index.js#L695 we do

     for (let i = 0; i < 16; i++) {
        state.activeAttributes[i] = null
        gl.disableVertexAttribArray(i)
      }

while https://kripken.github.io/emscripten-site/docs/optimizing/Optimizing-WebGL.html#avoid-redundant-calls explicitly says to avoid it

@dmnsgn dmnsgn added type/feat A new feature and removed enhancement labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feat A new feature
Projects
None yet
Development

No branches or pull requests

2 participants