Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BeautifulSoup for login #28

Open
chris001 opened this issue Sep 28, 2016 · 1 comment
Open

Use BeautifulSoup for login #28

chris001 opened this issue Sep 28, 2016 · 1 comment

Comments

@chris001
Copy link

This gvoice app should be modified to use BeautifulSoup html page processing class, which is already used in the example code, for processing the login and all other pages.

BeautifulSoup would be able to handle any minor changes (ie the order of tag elements should be irrelevant) in the html pages returned by google voice.

The code would be easier to improve on, fix bugs, and need to be updated far less often when page tags change position, since they will usually be found, regardless of position.

@pettazz
Copy link
Owner

pettazz commented Sep 28, 2016

You're probably right. Sounds like a good idea for a pull request

jaraco added a commit to jaraco/googlevoice that referenced this issue Aug 28, 2022
* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes pettazz#28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes jaraco/skeleton#34.

* Replace pep517.build with build (pettazz#37)

* Replace pep517.build with build

Resolves pettazz#30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <[email protected]>

* Use license_files instead of license_file in meta (pettazz#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants