Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox for if rupees behind board were collected #8

Open
csunday95 opened this issue Apr 23, 2020 · 3 comments
Open

Checkbox for if rupees behind board were collected #8

csunday95 opened this issue Apr 23, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request frontend-functionality issues related to non-UI portions of the frontend priority:medium Moderately high priority issues

Comments

@csunday95
Copy link
Collaborator

If the three rupees behind the board are collected, the RNG tick rate in the room is changed. A user entry method to indicate the rupee state is required for maximally accurate prediction of offset.

@csunday95 csunday95 added feature-request frontend-functionality issues related to non-UI portions of the frontend priority:medium Moderately high priority issues labels May 8, 2020
@csunday95
Copy link
Collaborator Author

appears to be partially implemented by @petersn at https://github.com/petersn/web-sploosh-kaboom/blob/master/src/App.js#L431 but commented out in current deployment

@csunday95 csunday95 added enhancement New feature or request and removed feature-request labels May 8, 2020
@csunday95 csunday95 added this to the V0.1.0 milestone May 9, 2020
@Amphitryon0
Copy link
Collaborator

I think the hardest part of this is designing what the feature should do. If there were no user-configurable settings, I would say it should adjust timer rate, timer intercept, room entered offset, timer standard deviation, reward offset, next board mean, and next board standard deviation. But with all of those except reward offset exposed to the user, the decision becomes much harder.

If we want to have this checkbox, then the user shouldn't need to configure anything else by default to use it. But we still want everything to be configurable, since the whole purpose of the configuration is to allow individualized or simply better known values to be used without us updating the site.

The best option I can think of is to duplicate all of these options and switch out which set we use based on this checkbox. Only the active set would be shown in the UI, but both sets would be saved locally to persist changes to them. This does have the issue that the user cannot see all of the settings at once, but I consider that relatively minor.

It also seems, based on Peter's incomplete implementation, that he wanted to support collecting the rupees while in the room and then immediately playing a game. In my opinion, this is way too complicated, and the best results we'll ever get with it will only be marginally better than not using the timer at all.

@Amphitryon0 Amphitryon0 removed this from the V0.1.0 milestone May 28, 2022
@Amphitryon0
Copy link
Collaborator

Regardless of how we may want to implement this checkbox in the future, there is currently nothing stopping users from manually entering the values needed to play with the rupees collected. Thus, I don't feel this should block the version 0.1.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend-functionality issues related to non-UI portions of the frontend priority:medium Moderately high priority issues
Projects
None yet
Development

No branches or pull requests

3 participants