Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering approvers should follow more rigorous rules #3

Open
peternied opened this issue Jan 9, 2024 · 0 comments
Open

Filtering approvers should follow more rigorous rules #3

peternied opened this issue Jan 9, 2024 · 0 comments

Comments

@peternied
Copy link
Owner

Coming from https://github.com/opensearch-project/OpenSearch/actions/runs/7464605190/job/20311941616?pr=11490#step:3:8

  • In the output it can be seen that there were multiple approvals from reta and peternied, they are being counted multiple times for the check of the number of required reviewers.

  • The pull request reviews responses also includes changes requested and dismissed reviews, these should be be properly computed as removing previous approved entries. Or at the very least there should be an option to control this behavior.

filtered to approvers:
 ["reta","peternied","reta","peternied"]
Found approvals from reta, peternied, reta, peternied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant