Update Init.php to change how Laravel is detected

[gregmsanderson]

What:

• Bug Fix
• New Feature

Description:

Running vendor/bin/pest --init currently checks for Laravel by looking for laravel/laravel however a new Laravel 11 install does not include that.

As a result isLaravelInstalled() incorrectly returns false

That means it does not add the Laravel stub and so defaults to using phpunit for the base case in TestCase.php. Which then causes an undefined error when running any Feature test, including the example one.

(I'm not sure if this is the only file that does this check however manually changing this file and then running vendor/bin/pest --init appears to fix it for me.)

Related:

#1192

[owenvoke]

I think an additional check is required (along with this one), as this would trigger on things such Laravel packages which shouldn't extend this testcase.

[gregmsanderson]

Ah, that's a good point. I'm not sure what the check would be to exclude those.

I guess the other way to do this would be for the user to tell the init command that Laravel is installed e.g vendor/bin/pest --init --laravel. That approach would mean the isLaravelInstalled check stays the same and so couldn't break anything (like a package). It would be nicer to automate it though.

[owenvoke]

I guess we could check if artisan exists maybe. 🤷🏻 That would handle most cases.

This is how Tinkerwell does it:
https://github.com/beyondcode/tinkerwell/blob/main/src/Drivers/LaravelTinkerwellDriver.php#L7

[gregmsanderson]

That makes sense. Perhaps:

private function isLaravelInstalled(): bool
{
   return file_exists($this->testSuite->rootPath.'/public/index.php') && file_exists($this->testSuite->rootPath.'/artisan');
}

... or get them all in there to cover all the bases ...

private function isLaravelInstalled(): bool
{
    return InstalledVersions::isInstalled('laravel/framework') && file_exists($this->testSuite->rootPath.'/public/index.php') && file_exists($this->testSuite->rootPath.'/artisan');
}

... since it looks like the equivalent to Tinkerwell's path is $this->testSuite->rootPath.

Perhaps checking for artisan alone is enough? I can't imagine you'd have one without the other, or create a file called artisan if not using Laravel.

[henzeb]

what if someone changed the name of that command file?

[gregmsanderson]

@henzeb If they did, yep, the new check would also fail to detect Laravel. Just like Tinkerwell would fail to.

Doing that seems less likely (to me anyway) than someone changing the name in composer.json.