Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected Rule is Not Saved When the Site Restarts #63

Closed
omer-biz opened this issue Sep 4, 2024 · 1 comment · Fixed by #64
Closed

Selected Rule is Not Saved When the Site Restarts #63

omer-biz opened this issue Sep 4, 2024 · 1 comment · Fixed by #64
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@omer-biz
Copy link
Contributor

omer-biz commented Sep 4, 2024

When I restart the site, the selected rule is lost and doesn't stay saved. It seems like the site isn't keeping track of the selected rules.

This might be connected to issues #61 and #43.

I tried to fix this in static/scripts/editor.ts by adding code to save and load the selected rules. But it looks like the rules get replaced by the WebAssembly (Wasm) module after the grammar is parsed, so my changes didn’t work.

I'm willing to fix these issues, but I’m not sure where to start. Any advice or tips would be really helpful.

@tomtau tomtau added enhancement New feature or request help wanted Extra attention is needed labels Sep 4, 2024
@tomtau
Copy link
Contributor

tomtau commented Sep 4, 2024

@omer-biz I think it gets set here: https://github.com/pest-parser/site/blob/master/src/lib.rs#L169 so probably that's a place to start?
@LeoDog896 @nathanielknight @Jamalam360

@tomtau tomtau linked a pull request Sep 5, 2024 that will close this issue
@tomtau tomtau closed this as completed in #64 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants