Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate book deployment #29

Open
LeoDog896 opened this issue Feb 23, 2023 · 3 comments
Open

Separate book deployment #29

LeoDog896 opened this issue Feb 23, 2023 · 3 comments

Comments

@LeoDog896
Copy link
Contributor

(Raising as an issue as this repository doesn't have discussions)

If instead of https://pest.rs/book, the book was located at https://book.pest.rs, we can seperate the build steps from the book and the site separately, allowing the book repo to contain its own CI/CD pipeline rather than relying on site.

@LeoDog896
Copy link
Contributor Author

(This also means that the book submodule doesn't have to be constantly updated).

@nathanielknight
Copy link
Contributor

This seem pretty sensible to me; the site and the book will probably have quite different release cadences in the long run.

That said, I'm not sure what the situation with the domain is, and getting book.pest.rs pointing at a separate GitHub Repo might not be possible (certainly not quickly).

Some options that occur to me are:

  • putting the book on a GitHub Pages domain and re-directing from pest.rs/book (which we can get done in this repo)
  • pulling the book into this repo as a sub-directory, which seems not ideal, but also it's how Rocket, Clap, Nom, and a bunch of other big crates seem to do it 🤷
  • putting this on ice until the domain situation can move forward

@LeoDog896 LeoDog896 changed the title Consider separate book deployment Separate book deployment Mar 15, 2023
@LeoDog896
Copy link
Contributor Author

I think we should probably do the first option now, then, once the domain issue is (hopefully) resolved, then we can move forward with the second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants