Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with mp3 plugin #116

Open
jareguero opened this issue Mar 28, 2018 · 6 comments
Open

Problem with mp3 plugin #116

jareguero opened this issue Mar 28, 2018 · 6 comments

Comments

@jareguero
Copy link

I have a problem with the mp3 plugin. The audio is stopped. Maybe the plugin is waiting fir video.

Mar 28 17:26:38 jar8 vdr: [7018] mp3: playback started with instant playlist 01-Miriam Rodríguez _ No Te Pude Retener.mp3
Mar 28 17:26:38 jar8 vdr: [7035] VAAPI: audio/alsa: using device 'hdmi'
Mar 28 17:26:38 jar8 vdr: [7035] VAAPI: audio/alsa: start delay 400ms
Mar 28 17:26:38 jar8 vdr: [7039] VAAPI-ERROR: video: slow down video, duping frame
Mar 28 17:26:38 jar8 vdr: [7039] VAAPI-ERROR: video: decoder buffer empty, duping frame (-943465032/-1341438688) 0 v-buf
Mar 28 17:26:38 jar8 vdr: [7039] VAAPI: video: --:--:--.--- +0 0 0/\ms 0+1 v-buf
Mar 28 17:26:44 jar8 vdr: [7035] VAAPI: audio/alsa: using device 'hdmi'
Mar 28 17:26:44 jar8 vdr: [7035] VAAPI: audio/alsa: start delay 400ms
Mar 28 17:26:44 jar8 vdr: [7018] switching to channel 173 T-8916-1012-532 (24h)

@jareguero
Copy link
Author

I found the commit that make mp3 plugin don't work. It is:
No soft start while replaying f604263
Reverting partially this commit, mp3 plugin work again.
diff --git a/audio.c b/audio.c
index e9d7288..1d6cd98 100644
--- a/audio.c
+++ b/audio.c
@@ -1361,8 +1361,9 @@ static int AudioNextRing(void)
if (remain <= AUDIO_MIN_BUFFER_FREE) {
Debug5("audio: force start");
}

  • if (remain <= AUDIO_MIN_BUFFER_FREE || ((AudioVideoIsReady || !SoftIsPlayingVideo)
  •   && AudioStartThreshold < used)) {
    
  • if (AudioStartThreshold * 4 < used || remain <= AUDIO_MIN_BUFFER_FREE ||
  •   ((AudioVideoIsReady || !SoftIsPlayingVideo) &&
    
  •   AudioStartThreshold < used)) {
    
    return 0;
    }
    return 1;
    @@ -1613,8 +1614,9 @@ void AudioEnqueue(const void *samples, int count)
    if (remain <= AUDIO_MIN_BUFFER_FREE) {
    Debug5("audio: force start");
    }
  • if (remain <= AUDIO_MIN_BUFFER_FREE || ((AudioVideoIsReady || !SoftIsPlayingVideo)
  •   && AudioStartThreshold < n)) {
    
  • if (AudioStartThreshold * 4 < n || remain <= AUDIO_MIN_BUFFER_FREE ||
  •     	((AudioVideoIsReady || !SoftIsPlayingVideo) &&
    
  •   AudioStartThreshold < n)) {
      // restart play-back
      // no lock needed, can wakeup next time
      AudioRunning = 1;
    

@9000h
Copy link
Contributor

9000h commented Apr 6, 2018

why not using insert "code", you patch is not readable as it is now

@jareguero
Copy link
Author

I think that it is attached now.

@jareguero
Copy link
Author

I don't know if the file is attached. I can't see it.

@jareguero
Copy link
Author

audio.txt
Now I tink that it is attached.

@ua0lnj
Copy link
Contributor

ua0lnj commented Jun 10, 2018

Hi. The patch helped me, it's works.

rofafor added a commit to rofafor/vdr-plugin-vaapidevice that referenced this issue Jul 21, 2018
rofafor added a commit to rofafor/vdr-plugin-vaapidevice that referenced this issue Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants