Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for synchronizer_cron_child_sites() #2

Open
marcoarthur opened this issue Jul 23, 2019 · 2 comments
Open

Write tests for synchronizer_cron_child_sites() #2

marcoarthur opened this issue Jul 23, 2019 · 2 comments
Assignees

Comments

@marcoarthur
Copy link
Member

Writing tests for the main function of the sync plugin. That do the heavy job for requesting the child. Maybe we should break it down in smaller functions, so we can unit test them better.

@marcoarthur marcoarthur self-assigned this Jul 23, 2019
@marcoarthur marcoarthur added this to the v1 - prototype milestone Jul 23, 2019
@marcoarthur
Copy link
Member Author

Class Child gets the following interface to handle Child sites:
Child( url ) constructor connects and retrieve posts from URL endpoint (/posts).
->sync() does the duty to make the mapping, saving unsaved or updated posts from URL

@marcoarthur
Copy link
Member Author

marcoarthur commented Jul 31, 2019

Something need to be checked since only 7.2 is passing the test on travis. Still we can review it.
https://travis-ci.org/perlcoder/wp-integration/jobs/566174696#L610 (pass)
https://travis-ci.org/perlcoder/wp-integration/jobs/566174697#L659 (failed)
https://travis-ci.org/perlcoder/wp-integration/jobs/566174698#L661 (failed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant