Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo #108

Open
djzort opened this issue Jul 24, 2019 · 2 comments
Open

Possible typo #108

djzort opened this issue Jul 24, 2019 · 2 comments

Comments

@djzort
Copy link
Collaborator

djzort commented Jul 24, 2019

DBD-Oracle/lib/DBD/Oracle.pm

Line 938 in cfc9176

"TIMESTAMP'", # literal prefix

The single quote might be a typo
@djzort
Copy link
Collaborator Author

djzort commented Jul 24, 2019

There is also the same thing a little ways down with "INTERVAL'"

@mjegh
Copy link
Member

mjegh commented Jul 24, 2019

It is more likely the TIMESTAMP and INTERVAL are a typo IMHO as it is the literal prefix which is usually a single quote but I'm not 100% sure. It has been that way for ages and that doesn't surprise me as I doubt anyone using D::O will actually read the literal suffix/prefix from that definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djzort @mjegh