Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point manpages to man7.org (supporting HTTPS and anchors) #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Point manpages to man7.org (supporting HTTPS and anchors) #172

wants to merge 1 commit into from

Conversation

rwp0
Copy link
Contributor

@rwp0 rwp0 commented Jul 26, 2024 •
edited
Loading

Instead of HTTP-only man.he.net

Avoiding "Not secure" warnings thereby

Fixes #150

Symbols

  • resolve_man_page_link method
  • $Man_URL_Prefix: man_url_prefix() (accessorized)
  • $Man_URL_Postfix: man_url_postfix() (accessorized)

@rwp0
Copy link
Contributor Author

rwp0 commented Jul 26, 2024 •
edited
Loading

Dear @khwilliamson and @haarg,

Please approve workflows so I can study and work through them to see what fails and what succeeds easily.

@rwp0 rwp0 force-pushed the rwp0/man7 branch 2 times, most recently from 6036233 to 84e3b6b Compare July 27, 2024 00:31
mauke
mauke reviewed Jul 27, 2024
View reviewed changes
lib/Pod/Simple/HTML.pm Show resolved Hide resolved
lib/Pod/Simple/XHTML.pm Outdated Show resolved Hide resolved
lib/Pod/Simple/XHTML.pm Outdated Show resolved Hide resolved
t/fcodes_s.t Outdated Show resolved Hide resolved
rwp0
rwp0 commented Jul 27, 2024
View reviewed changes
lib/Pod/Simple/HTML.pm Outdated Show resolved Hide resolved
lib/Pod/Simple/XHTML.pm Outdated Show resolved Hide resolved
@rwp0
Copy link
Contributor Author

rwp0 commented Jul 28, 2024 •
edited
Loading

Oh, every new workflow requires approval (upon force-pushing) 😞

OK let's build on the previous one:
https://github.com/perl-pod/pod-simple/actions/runs/10119322893/job/27989146494#step:6:159

#   Failed test at t/fcodes_s.t line 241.
#          got: '
# <p><a href="https://man7.org/linux/man-pages5/crontab.5.html" class="podlinkman"
# >crontab(5)</a></p>
# '
#     expected: '
# <p><a href="https://man7.org/linux/man-pages5/crontab" class="podlinkman"
# >crontab(5)</a></p>
# '

#   Failed test at t/fcodes_s.t line 301.
#          got: '
# <p><a href="https://man7.org/linux/man-pages5/crontab.5.html" class="podlinkman"
# >things</a></p>
# '
#     expected: '
# <p><a href="https://man7.org/linux/man-pages5/crontab" class="podlinkman"
# >things</a></p>
# '

#   Failed test at t/fcodes_s.t line 306.
#          got: '
# <p><a href="https://man7.org/linux/man-pages5/crontab.5.html" class="podlinkman"
# >things</a></p>
# '
#     expected: '
# <p><a href="https://man7.org/linux/man-pages5/crontab" class="podlinkman"
# >things</a></p>
# '
# Looks like you failed 3 tests of 78.
t/fcodes_s.t ......... 
Dubious, test returned 3 (wstat 7[68](https://github.com/perl-pod/pod-simple/actions/runs/10119322893/job/27989146494#step:6:69), 0x300)
Failed 3/78 subtests

@rwp0
Copy link
Contributor Author

rwp0 commented Jul 28, 2024

@mauke @khwilliamson
Can someone please approve the workflow again?
It's easier for me to work through them.

@rwp0 rwp0 force-pushed the rwp0/man7 branch 2 times, most recently from e3701b9 to 1b91a88 Compare July 28, 2024 13:13
@rwp0 rwp0 changed the title Point manpages to man7.org (HTTPS) Point manpages to man7.org (supporting HTTPS and anchors) Jul 28, 2024
@rwp0
Point manpages to man7.org (HTTPS)
442b763 
Instead of HTTP-only man.he.net

Avoiding "Not secure" warnings thereby

Fixes perl-pod#150
@khwilliamson
Copy link
Contributor

What is the status of this. I thought I saw some stuff on irc about this. That should go in the comments here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauke mauke mauke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace HTTP man.he.net with HTTPS man7.org manpages
3 participants
@rwp0 @khwilliamson @mauke