Better validations against internal URLs #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperichon
changed the title
|
@kritik let me know what you think! |
jperichon
changed the title
|
@jperichon I like the idea of blacklisted domains but not of internal IPs. It adds big complexity but I don't see any reason why anyone would use that. Maybe spit commits by two merge requests? |
|
@kritik Thanks for the quick review, I will split the PR. I agree on the complexity for detecting internal IPs, but this extended validation can be used to prevent SSRF attacks and make the feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to extend the coverage of local hosts detection and also allow blacklisting of some domains (eg: internal domains).