Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize TLS and CA certificate file writes in getMongoUri function #1736

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize TLS and CA certificate file writes in getMongoUri function #1736

wants to merge 1 commit into from
+32 −12

Conversation

clsv
Copy link
Contributor

@clsv clsv commented Nov 23, 2024 •
edited
Loading

Problem:
The function getMongoUri always rewrites the TLS PEM and CA certificate files, even if their content hasn't changed. This unnecessary file I/O is inefficient and may cause issues during critical operations, such as when the operator checks the backup process.

Cause:
The implementation does not verify whether the existing file content matches the secret data before overwriting the files, leading to constant and redundant updates.

Solution:
Added logic to compare the content of the existing files with the secret data. Files are only overwritten if the data has changed, preventing redundant writes and ensuring smoother operations during backup checks.

Resolves #1723

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Nov 23, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-fs passed
demand-backup-eks-credentials-irsa passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service failure
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 53 out of 53

commit: 2e957b3
image: perconalab/percona-server-mongodb-operator:PR-1736-2e957b3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hors hors Awaiting requested review from hors hors is a code owner

@egegunes egegunes Awaiting requested review from egegunes egegunes is a code owner

@inelpandzic inelpandzic Awaiting requested review from inelpandzic inelpandzic is a code owner

@pooknull pooknull Awaiting requested review from pooknull pooknull is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
community size/M 30-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error status on successful backups due to certificate retrieval issue
3 participants
@clsv @JNKPercona @inelpandzic