Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling errors #60

Open
nsheff opened this issue Jun 9, 2023 · 1 comment
Open

Handling errors #60

nsheff opened this issue Jun 9, 2023 · 1 comment
Assignees
@nsheff
Labels
question Further information is requested

Comments

@nsheff
Copy link
Contributor

nsheff commented Jun 9, 2023

Right now, the validation functions are printing out notices and then raising exceptions. Instead, what if the raising of exception should happen by the calling tool?

The validation function would collect and format the errors. Then, the calling function should decide what to do with it. For example, in the case of the CLI, it should print it out. But in other cases, we may just want a list of the validation error. So, should the printing move from the validation function to the calling context?
@nsheff nsheff added the question Further information is requested label Jun 9, 2023
@nsheff nsheff self-assigned this Jun 12, 2023
@nsheff nsheff added this to PEP Vision Oct 5, 2023
@nsheff
Copy link
Contributor Author

nsheff commented Oct 5, 2023

We may have addressed this to some degree in f517108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsheff nsheff

Labels
question Further information is requested
Projects
No open projects
PEP Vision
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nsheff