Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect card heights #53

Closed
tomzemp opened this issue Jan 30, 2020 · 1 comment
Closed

Incorrect card heights #53

tomzemp opened this issue Jan 30, 2020 · 1 comment
Assignees

Comments

@tomzemp
Copy link
Contributor

tomzemp commented Jan 30, 2020

When working on updating header bar (#52), noticed inconsistent heights for cards when deployed:

image

tomzemp pushed a commit that referenced this issue Jan 30, 2020
@tomzemp tomzemp self-assigned this Jan 30, 2020
@tomzemp
Copy link
Contributor Author

tomzemp commented Jan 30, 2020

issue was that card height was not being updated as only set in componentDidMount hook. Added to componentDidUpdate hook (and slightly rewrote)

@tomzemp tomzemp closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant