-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum Viable Product - Review #27
Comments
Looks great, @tomzemp! A few minor comments and a major one. Minor comments first:
Now the major issue. As I clicked around, I saw some bizarre formatting issues. Are these anything that you've seen before? I didn't do anything remarkable—simply clicked between the two options of where to search for more info: Once these are all resolved, maybe let's take it back to Josephine and someone from the PMO side to review, and then plan for a deploy? |
@benguaraldi @jakub-bao I redid the styles (#19 (comment)) and now it looks like I'm not getting weird styling problems when things are rerendered Also (logo is fixed :-) ) I will plan on passing back to Josephine, Celeste, and Michelle for comments unless I hear otherwise from you. |
congratulations!! |
@tomzemp Please pass on to Josephine, Celeste, and Michelle for comments. Can they also test it, or should someone else do that? |
Hi @benguaraldi @jakub-bao:
I have a minimum viable product of the React datim mechanism finder app deployed on dev-tom.datim.org (it's called
DATIM Mechanism Finder
whereas the old Angular one is calledMechanism Finder
I wrote a couple of cypress tests when I started, but I can go back and now write them more fully. Other than that, I'm not sure what you want to do in terms of review/soliciting feedback
The text was updated successfully, but these errors were encountered: