Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Viable Product - Review #27

Open
tomzemp opened this issue Jul 1, 2019 · 4 comments
Open

Minimum Viable Product - Review #27

tomzemp opened this issue Jul 1, 2019 · 4 comments
Assignees

Comments

@tomzemp
Copy link
Contributor

tomzemp commented Jul 1, 2019

Hi @benguaraldi @jakub-bao:

I have a minimum viable product of the React datim mechanism finder app deployed on dev-tom.datim.org (it's called DATIM Mechanism Finder whereas the old Angular one is called Mechanism Finder

image

I wrote a couple of cypress tests when I started, but I can go back and now write them more fully. Other than that, I'm not sure what you want to do in terms of review/soliciting feedback

@benguaraldi
Copy link
Contributor

benguaraldi commented Jul 2, 2019

Looks great, @tomzemp! A few minor comments and a major one.

Minor comments first:

  1. It seems like it's having trouble loading the DATIM logo:

Screen Shot 2019-07-02 at 1 23 12 PM

  1. The table doesn't span the same width as the three boxes:
    Screen Shot 2019-07-02 at 1 29 46 PM

  2. Having the scroll bar at the bottom of the window rather than at the bottom of the page is fantastic! It's a better solution than having it in the middle of the page, as I proposed.

Now the major issue. As I clicked around, I saw some bizarre formatting issues. Are these anything that you've seen before? I didn't do anything remarkable—simply clicked between the two options of where to search for more info:
Screen Shot 2019-07-02 at 1 25 05 PM
Screen Shot 2019-07-02 at 1 24 46 PM
Screen Shot 2019-07-02 at 1 24 14 PM
Screen Shot 2019-07-02 at 1 24 07 PM

Once these are all resolved, maybe let's take it back to Josephine and someone from the PMO side to review, and then plan for a deploy?

@tomzemp
Copy link
Contributor Author

tomzemp commented Aug 9, 2019

@benguaraldi @jakub-bao I redid the styles (#19 (comment))

and now it looks like I'm not getting weird styling problems when things are rerendered
mechFinderDevTom

Also (logo is fixed :-) )

I will plan on passing back to Josephine, Celeste, and Michelle for comments unless I hear otherwise from you.

@jakub-bao
Copy link
Contributor

congratulations!!

@benguaraldi
Copy link
Contributor

@tomzemp Please pass on to Josephine, Celeste, and Michelle for comments. Can they also test it, or should someone else do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants