Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Agency/Partner Mechanisms #10

Open
tomzemp opened this issue May 28, 2019 · 4 comments
Open

Multiple Agency/Partner Mechanisms #10

tomzemp opened this issue May 28, 2019 · 4 comments
Assignees

Comments

@tomzemp
Copy link
Contributor

tomzemp commented May 28, 2019

Investigate what a multiple agency/partner is for end users

@tomzemp
Copy link
Contributor Author

tomzemp commented May 28, 2019

@benguaraldi: following up on the requirement changes, I looked into adding support for multiple agencies for a given mechanism...the problem is I can't find any with the current logic

The code looks at each mechanism (category option) and then looks through its associated categoryOptionGroups. The categoryOptionGroup that has a code that starts with Agency_ is marked as the agency for the mechanism.

I cannot find any mechanisms that have more than 1 category option group with a code that starts with Agency_ (or with Partner_ for that matter). (I checked that with: https://github.com/pepfar-datim/datim-mechanism-finder/blob/tom/research/print_multiple_agency_COs.py)

Is there some other logic that Josephine might explain why Josephine says that there are mechanisms with multiple agencies? Could it be relevant for her if the Partner is shared with multiple agencies, rather than the mechanism itself?

@tomzemp tomzemp self-assigned this May 29, 2019
@tomzemp tomzemp added the MVP Minimum Viable Product (first React Rollout) label May 29, 2019
@tomzemp
Copy link
Contributor Author

tomzemp commented May 29, 2019

Also, FYI @hardingt if you have any ideas

@benguaraldi
Copy link
Contributor

@tomzemp There shouldn't be any mechanisms with multiple agencies. Every mechanism has one and only one agency, partner, and operating unit.

Maybe Josephine meant something else?

(Sorry for the delayed response on this.)

@benguaraldi benguaraldi removed the MVP Minimum Viable Product (first React Rollout) label Jun 13, 2019
@tomzemp
Copy link
Contributor Author

tomzemp commented Jun 13, 2019

After discussing this with @benguaraldi, we assume that Josephine is referring to cases where the Partner has multiple agencies within a given OU, this would mean that users would need to be created by an Interagency User.

In this case, we may want to display this information in the Partners box...but we will need to modify the app more to make subsequent calls to determine agencies for partner related to a given mechanism within a given OU...so unmarking it as MVP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants