Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8ify won't run multiple times #88

Open
sauln opened this issue May 1, 2018 · 2 comments
Open

pep8ify won't run multiple times #88

sauln opened this issue May 1, 2018 · 2 comments
Labels

Comments

@sauln
Copy link

sauln commented May 1, 2018

First off, thank you for this great tool! I've been using pep8speaks and it's automatic pull requests in all my projects.

Most recently, I've been working on a PR for a while and have tried using the pep8ify command multiple times, but it hasn't worked.

Steps

Initially, I issued the PR and added a comment @pep8speaks pep8ify. I then merged the suggested changes. A few days later, after more commits were added, pep8speaks updated correctly. Then I tried issuing the command @pep8speaks pep8ify again so pep8speaks would create another PR.

Result

It looks like, pep8speaks made a fork of the library, but never issued a pull request. You can see here pep8speaks/pep8speaks@5cfadbc that it even made the commits with the changes.

The PR I've been working on is scikit-tda/kepler-mapper#77. I have manually created a new pull request from pep8speak's fork.

@OrkoHunter
Copy link
Collaborator

Hello @sauln! Thank you for trying out PEP8Speaks!
I can confirm that this is clearly an issue since pep8ify is currently designed to be used only once per PR. Looking at the case of kepler-mapper, I think it should be redesigned to be called multiple times. Unfortunately, I don't seem to find much time to work on this in near future.

@OrkoHunter OrkoHunter added the bug label May 1, 2018
@sauln
Copy link
Author

sauln commented May 10, 2018

Hi @OrkoHunter. Thanks for getting back to me. I love PEP8Speaks!

As a temporary work around, I've found that if I delete my original comment calling pep8ify and delete pep8speaks' comment "Here you go...", then it will issue a second pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants