Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get and order by priority from registry #1829

Closed
grod220 opened this issue Oct 4, 2024 · 2 comments
Closed

Get and order by priority from registry #1829

grod220 opened this issue Oct 4, 2024 · 2 comments
Assignees
Labels
rpc Related to proto rpc services/methods ui Related to user interface or ux design

Comments

@grod220
Copy link
Collaborator

grod220 commented Oct 4, 2024

At the moment, minifront displays assets in arbitrary order:

Screenshot 2024-10-04 at 12 34 11 PM

The issue is that not all of these assets are equally important. Ideally, the most relevant ibc assets get shown on top.

For that, minifront needs to rely upon Metadata priority score which it gets when it requests from the rpc (in BalancesRequest and AssetsRequest).

Task:

  • Add priority scores to registry for assets: https://github.com/prax-wallet/registry
  • Update rpc methods that return denom metadata to reference registry priority scores
  • Update minifront to utilize priority score for ordering in assets selector
@grod220 grod220 added ui Related to user interface or ux design rpc Related to proto rpc services/methods labels Oct 4, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Oct 4, 2024
@grod220 grod220 moved this to 📝 Todo in Labs web Oct 4, 2024
@grod220 grod220 added this to Labs web Oct 4, 2024
@JasonMHasperhoven JasonMHasperhoven self-assigned this Oct 14, 2024
@TalDerei
Copy link
Contributor

closed by prax-wallet/registry#96?

@grod220
Copy link
Collaborator Author

grod220 commented Oct 21, 2024

That's only part 1, we need to implement it into minifront & use in rpc. In progress: #1860

@grod220 grod220 closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc Related to proto rpc services/methods ui Related to user interface or ux design
Projects
Archived in project
Development

No branches or pull requests

3 participants