Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of a raw indexer #78

Closed
wants to merge 24 commits into from
Closed

Remove the use of a raw indexer #78

wants to merge 24 commits into from

Conversation

cronokirby
Copy link
Contributor

Closes #49.

Apologies for the big PR.

This removes the use of the old indexer, replacing it instead with the new indexing database, derived after running pindexer.

This also introduces some amount of typing into the API calls, using Zod Schemas.
I decided to not put also playing around with TRPC or some other typed API system here, to avoid having too much in a single pull request.

I also updated the frontend as necessary to use the new typed api routes I introduced; as a consequence I rewrote the component displaying the events of a position, as a consequence removing a lot of code.

@conorsch
Copy link
Contributor

This is huge. I defer to web team on the suitability of the refactoring, but lgtm. Making this change will require some comms because a new db backend is required. In order to evaluate these changes on the testnet, we must resolve #73, so I'd prefer that change lands first, so we have working asset display on the old db backend on the testnet instance, then we can proceed with updating the deployment to use the new db and confirm no regressions or breakage.

Regarding release comms, I think we can be a lot more explicit about the db backend in the README, but we don't need to solve that problem now.

@conorsch
Copy link
Contributor

conorsch commented Oct 3, 2024

In order to evaluate these changes on the testnet, we must resolve #73, so I'd prefer that change lands first

We have a candidate PR for resolving #73 in #80 now, which is undergoing review.

@conorsch
Copy link
Contributor

conorsch commented Oct 9, 2024

We have automatic deployments to testnet again (#72). Switching to a different schema on the backend will be a breaking change, but it looks like this PR won't be landing soon, given the conflicts. Just holler at me when we're closer to the finish line, and I'll make sure the backend databases are configured correctly on the testnet-facing deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on raw events database
2 participants