-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the use of a raw indexer #78
Conversation
This is huge. I defer to web team on the suitability of the refactoring, but lgtm. Making this change will require some comms because a new db backend is required. In order to evaluate these changes on the testnet, we must resolve #73, so I'd prefer that change lands first, so we have working asset display on the old db backend on the testnet instance, then we can proceed with updating the deployment to use the new db and confirm no regressions or breakage. Regarding release comms, I think we can be a lot more explicit about the db backend in the README, but we don't need to solve that problem now. |
This way frontend code can import it without feeling bad.
As a consequence we implement some basic zod stuff here too.
Makes things easier to compose
in particular, the old indexer
c7fc6c2
to
500481d
Compare
We have automatic deployments to testnet again (#72). Switching to a different schema on the backend will be a breaking change, but it looks like this PR won't be landing soon, given the conflicts. Just holler at me when we're closer to the finish line, and I'll make sure the backend databases are configured correctly on the testnet-facing deployment. |
Closes #49.
Apologies for the big PR.
This removes the use of the old indexer, replacing it instead with the new indexing database, derived after running pindexer.
This also introduces some amount of typing into the API calls, using Zod Schemas.
I decided to not put also playing around with TRPC or some other typed API system here, to avoid having too much in a single pull request.
I also updated the frontend as necessary to use the new typed api routes I introduced; as a consequence I rewrote the component displaying the events of a position, as a consequence removing a lot of code.