Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When resubmit for review, bot didn't notify claimed reviewer #40

Open
hauvong opened this issue Sep 13, 2023 · 0 comments
Open

When resubmit for review, bot didn't notify claimed reviewer #40

hauvong opened this issue Sep 13, 2023 · 0 comments

Comments

@hauvong
Copy link
Contributor

hauvong commented Sep 13, 2023 •
edited
Loading

  • When a queued item is resubmit for review, only the approvers & changes request get tagged/notify
  • We should notify the claimed reviewer as well since there are changes that need a re-review.
  • Bonus: If we can also notify the channel, that would help since the threaded messages might be very old.
@hauvong hauvong changed the title When resubmit for review, bot didn't notice claimed reviewer When resubmit for review, bot didn't notify claimed reviewer Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hauvong