Safe check json for checking is_wharton

pennlabs · Sep 10, 2023 · e5a0341 · e5a0341
1 parent 7291d8e
commit e5a0341
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/backend/gsr_booking/models.py b/backend/gsr_booking/models.py
@@ -50,10 +50,15 @@ def check_wharton(self):
         try:
             response = requests.get(
                 url, headers={"Authorization": f"Token {settings.WHARTON_TOKEN}"}
-            ).json()
-            if "type" in response:
+            )
+
+            if response.status_code != 200:
+                return None
+
+            res_json = response.json()
+            if "type" in res_json:
                 # check if user is wharton
-                return response["type"] == "whartonMBA" or response["type"] == "whartonUGR"
+                return res_json["type"] == "whartonMBA" or res_json["type"] == "whartonUGR"
             else:
                 # accomodate for inconsistent responses
                 return False