Enable pedantic clippy on all crates and deal with the fallout

[davidv1992]

We really should do as it would have prevented a bug. But this is going to take some effort... Be prepared that this is not the most fun task.

Also, be carefull not to introduce msrv changes with this.

[van-sprundel]

I would like to work on this, but I was wondering which bug could've been prevented with the pedantic lint group.

[davidv1992]

We had a bug in our time jump handling in which we did not properly correct the filter state for the jump, due to ignoring the return value of a function. This is the specific example we have right now. The pedantic lints would have caught that particular pattern (as the function was a pure function).

[van-sprundel]

I'm not sure how to keep the impact minimal. The big one is ntp-proto, which has ~1000 loc changed. Do we just accept that this is going to conflict with other PRs?

[davidv1992]

O wow, that is quite some impact, even more than I would have expected. Given that I do expect all of these to be small changes individually, I think accepting that it is going to give some headaches is the best we can do.

Should any larger restructurings be necessary in places, please do split of those into separate PRs if possible. Then we can deal with those before the large but mostly simple pr.

[van-sprundel]

What I can do is split the docs changes into a separate PR, then split it again for each crate. That should make it nicer to review at least

[davidv1992]

Please wait one moment still. The doc changes aren't the problem, but I will post a review once I am done with it that does ask for a few splitups/changes

[davidv1992]

Added review.

Note to self: we need to keep this issue open on merging that, as there is still quite some work to do cleaning up the allow marked areas. Need to reconsider then how beginner friendly that work is though.