Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define storage migrations required to upgrade from Polkadot 1.1.0 to 1.6.0 #506

Open
gianfra-t opened this issue Oct 24, 2024 · 4 comments
Assignees

Comments

@gianfra-t
Copy link
Contributor

gianfra-t commented Oct 24, 2024

Context

As part of the master task of updating to Polkadot 1.6.0 (see tasks/#419) we need to identify which migrations need to be defined manually and added to the runtime before performing the upgrade.

Migrations that need to be specified manually are to be defined in the runtime as it was done here, where the migration functions are defined on the corresponding pallet.

Steps

Use the information here regarding storage version management of the pallets.

Ideally, the process should be:

  • For each pallet:
    • Identify the current storage version, in polkadot-v1.1.0.
    • Identify the version that polkadot-v1.6.0 uses.
    • Check if the pallet defines a migration automatically or needs to be specified manually.
    • If it doesn't specify automatically, identify which migration functions must be called.

The migration code should be added to the modifications done for this issue and removed after the upgrade is enacted.

The results can be summarized in a Notion page analogous to this one.

Results

Migration analysis from 1.1.0 to 1.6.0 can be found here.

@prayagd
Copy link
Collaborator

prayagd commented Nov 4, 2024

Hey team! Please add your planning poker estimate with Zenhub @b-yap @ebma @gianfra-t @TorstenStueber

@ebma ebma self-assigned this Nov 20, 2024
@ebma
Copy link
Member

ebma commented Nov 22, 2024

@techies I'm done looking at the pallets, the results are here. To me it seems like we only need to configure two migrations, 1) a migration for cumulus_pallet_xcmp_queue and 2) a migration for pallet_identity.

@TorstenStueber
Copy link
Member

Great overview. Okay, then let's go ahead to add these migrations. Are these automatic migrations or migrations we would need to define manually?

@ebma
Copy link
Member

ebma commented Nov 25, 2024

As far as I can tell both migrations are manual and require us to define them in the Executive type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants