Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

venue work: changes to how ampersands are parsed #120

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented Sep 1, 2020

This PR changes to how ampersands are handled with a preference for venues over intersections in some cases.

The work is motivated by the parser having poor support for things like "Bar & Grill" (and venue names containing ampersands in general)

the diff looks like more changes than it really is 😄

the main difference is in parser/AddressParser.js

  • change the order which the "phrase classifiers" are listed to put "PlaceClassifier" above "IntersectionClassifier".

this allows us to change the behaviour of "IntersectionClassifier" to allow this exception:

  • do not classify 'and' sandwiched by two 'PlaceClassification' as an 'IntersectionClassification' (eg. 'Bar & Restaurant')

making this change means that it's possible to see odd classifications such as '& grill' as a street, to resolve this I've added not: 'PunctuationClassification' in many places to differentiate from an AlphaClassification.

still a DRAFT PR for now, needs more testing before opening up for merging.

… preferrence for venues over intersections in some cases
@missinglink
Copy link
Member Author

missinglink commented Sep 1, 2020

one of the issues with this method is that there will be 'jitter' for partially complete inputs, eg:

'foo & bar'

(0.80) ➜ [ { venue: 'foo & bar' } ]
(0.70) ➜ [ { street: 'foo' }, { street: 'bar' } ]
'foo & ba'

(0.68) ➜ [ { street: 'foo' }, { street: 'ba' } ]

... although this might not be an issue in pelias/api, depending on how it's converted to an ES query in pelias/api#1487

[edit] pelias/api@50c15db shows it's not an issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant